Parse as float and then round to int #356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandromoreira
approved these changes
Feb 7, 2024
| @@ -959,7 +959,10 @@ def __init__(self, uri, stream_info, media, base_uri): | |||
| if resolution is not None: | |||
| resolution = resolution.strip('"') | |||
| values = resolution.split("x") | |||
| resolution_pair = (int(values[0]), int(values[1])) | |||
| resolution_pair = ( | |||
| int(round(float(values[0]))), | |||
There was a problem hiding this comment.
just out of curiosity: is there any packager outputting manifests with decimal resolution?
There was a problem hiding this comment.
I had some example files I was testing with that had 1280.0x720.0 but I'm not sure where they came from. ffmpeg outputs them as integers and I assume that most do as well
There was a problem hiding this comment.
no worries, thank you
|
H264 uses integers to represent resolution. I think we should avoid adding unnecessary changes. |
|
Closing since this is out of spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355